avoid console call in our unit tests (#27790)

twbs · Dec 6, 2018 · fa03289 · fa03289
1 parent 947f749
commit fa03289
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/js/tests/unit/.eslintrc.json b/js/tests/unit/.eslintrc.json
@@ -20,7 +20,7 @@
   },
   "extends": "../../../.eslintrc.json",
   "rules": {
-    "no-console": "off",
+    "no-console": "error",
     // Best Practices
     "consistent-return": "off",
     "no-magic-numbers": "off",

diff --git a/js/tests/unit/tooltip.js b/js/tests/unit/tooltip.js
@@ -563,7 +563,6 @@ $(function () {
       $tooltip.bootstrapTooltip('show')
     } catch (err) {
       passed = false
-      console.log(err)
     }
 
     assert.ok(passed, '.tooltip(\'show\') should not throw an error if element no longer is in dom')

diff --git a/js/tests/unit/util.js b/js/tests/unit/util.js
@@ -137,7 +137,6 @@ $(function () {
     var shadowRoot = $div[0].attachShadow({
       mode: 'open'
     })
-    console.warn($div[0].attachShadow, shadowRoot)
 
     assert.equal(shadowRoot, Util.findShadowRoot(shadowRoot))
     shadowRoot.innerHTML = '<button>Shadow Button</button>'