enforce element check on scrollspy target

twbs · May 7, 2020 · 22f75ca · 22f75ca
1 parent 5f267b1
commit 22f75ca
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/js/src/scrollspy.js b/js/src/scrollspy.js
@@ -157,7 +157,7 @@ class ScrollSpy {
       ...typeof config === 'object' && config ? config : {}
     }
 
-    if (typeof config.target !== 'string') {
+    if (typeof config.target !== 'string' && Util.isElement(config.target)) {
       let id = $(config.target).attr('id')
       if (!id) {
         id = Util.getUID(NAME)

diff --git a/js/tests/unit/scrollspy.js b/js/tests/unit/scrollspy.js
@@ -127,7 +127,7 @@ $(function () {
       .show()
       .find('#scrollspy-example')
       .bootstrapScrollspy({
-        target: document.getElementById('#ss-target')
+        target: document.getElementById('ss-target')
       })
 
     $scrollspy.one('scroll', function () {

diff --git a/site/docs/4.4/components/scrollspy.md b/site/docs/4.4/components/scrollspy.md
@@ -314,7 +314,7 @@ Options can be passed via data attributes or JavaScript. For data attributes, ap
     </tr>
     <tr>
       <td>target</td>
-      <td>string</td>
+      <td>string | jQuery object | DOM element</td>
       <td></td>
       <td>Specifies element to apply Scrollspy plugin.</td>
     </tr>