Vergrth16 base #37
Merged
Vergrth16 base #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2024 08:47
alinaT95
force-pushed
the
vergrth16_base
branch
from
3767bc6
to
6ce44f3
Compare
SeHor05
approved these changes
Oct 4, 2024
SilkovAlexander
requested changes
Oct 8, 2024
tvm_vm/src/executor/zk.rs
Outdated
| let address_seed = Bn254FrElement::from_str(address_seed).unwrap(); | ||
| let addr_seed = (&address_seed).into(); | ||
|
|
||
| let (first, second) = split_to_two_frs(eph_pk_bytes).unwrap(); |
There was a problem hiding this comment.
Remove pure unwraps, fn should return Err on bad arguments
- I think it's bad thing to pass json encoded parameters as an argument
SilkovAlexander
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.