Issue helidon-io#8613 - Review notes applied.

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
tvallin · Jul 24, 2024 · c974591 · c974591
1 parent af38817
commit c974591
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/dbclient/dbclient/src/main/java/io/helidon/dbclient/DbClientBuilderBase.java b/dbclient/dbclient/src/main/java/io/helidon/dbclient/DbClientBuilderBase.java
@@ -50,7 +50,6 @@ public abstract class DbClientBuilderBase<T extends DbClientBuilderBase<T>>
      */
     protected DbClientBuilderBase() {
         this.clientServices = new LinkedList<>();
-        this.missingMapParametersAsNull = false;
     }
 
     @Override

diff --git a/dbclient/dbclient/src/main/java/io/helidon/dbclient/DbClientContext.java b/dbclient/dbclient/src/main/java/io/helidon/dbclient/DbClientContext.java
@@ -122,7 +122,6 @@ public abstract static class BuilderBase<B extends BuilderBase<B, T>, T extends
          * Creates an instance of base builder for {@link DbClientContext}.
          */
         protected BuilderBase() {
-            this.missingMapParametersAsNull = false;
         }
 
         /**

diff --git a/dbclient/jdbc/src/main/java/io/helidon/dbclient/jdbc/JdbcStatement.java b/dbclient/jdbc/src/main/java/io/helidon/dbclient/jdbc/JdbcStatement.java
@@ -148,12 +148,16 @@ private PreparedStatement prepareNamedStatement(String stmtName, String stmt, Ma
             for (String name : namesOrder) {
                 if (parameters.containsKey(name)) {
                     Object value = parameters.get(name);
-                    LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> %s", i, name, value));
+                    if (LOGGER.isLoggable(Level.TRACE)) {
+                        LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> %s", i, name, value));
+                    }
                     setParameter(preparedStatement, i, value);
                     i++;
                 } else {
                     if (context().missingMapParametersAsNull()) {
-                        LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> null", i, name));
+                        if (LOGGER.isLoggable(Level.TRACE)) {
+                            LOGGER.log(Level.TRACE, String.format("Mapped parameter %d: %s -> null", i, name));
+                        }
                         setParameter(preparedStatement, i, null);
                         i++;
                     } else {
@@ -174,7 +178,9 @@ private PreparedStatement prepareIndexedStatement(String stmtName, String stmt,
             preparedStatement = prepareStatement(stmtName, stmt);
             int i = 1; // JDBC set position parameter starts from 1.
             for (Object value : parameters) {
-                LOGGER.log(Level.TRACE, String.format("Indexed parameter %d: %s", i, value));
+                if (LOGGER.isLoggable(Level.TRACE)) {
+                    LOGGER.log(Level.TRACE, String.format("Indexed parameter %d: %s", i, value));
+                }
                 setParameter(preparedStatement, i, value);
                 i++;
             }