Skip to content

Commit

Permalink
drm/bridge: anx7625: fix an error code in anx7625_register_audio()
Browse files Browse the repository at this point in the history
This code accidentally returns IS_ERR(), which is 1, instead of
propagating the negative error code.  The caller doesn't check for
errors so it doesn't affect run time at all.

Fixes: 566fef1 ("drm/bridge: anx7625: add HDMI audio function")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211124145219.GD13656@kili
  • Loading branch information
Dan Carpenter authored and robertfoss committed Nov 25, 2021
1 parent 0bae568 commit 83ddd80
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/bridge/analogix/anx7625.c
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx)
sizeof(codec_data));

if (IS_ERR(ctx->audio_pdev))
return IS_ERR(ctx->audio_pdev);
return PTR_ERR(ctx->audio_pdev);

DRM_DEV_DEBUG_DRIVER(dev, "bound to %s", HDMI_CODEC_DRV_NAME);

Expand Down

0 comments on commit 83ddd80

Please sign in to comment.