Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UnreadMailStateService for read/unread #8507

Open
2 tasks
Tracked by #8505
charlag opened this issue Feb 10, 2025 · 0 comments · Fixed by #8512
Open
2 tasks
Tracked by #8505

Use UnreadMailStateService for read/unread #8507

charlag opened this issue Feb 10, 2025 · 0 comments · Fixed by #8512
Assignees
@paw-hub
Labels
feature: conversation view

Comments

@charlag
Copy link
Contributor

charlag commented Feb 10, 2025 •
edited by paw-hub
Loading

Normally to mark mails as read/unread we call PUT on mails.
In case of conversations we will also know the mail ids so we need to mark mails as unread based on that.
We already have a service for doing exactly that and we should use it. We should use it also when the conversation grouping is not enabled.

Estimated: 2h
Time taken: 1.5h

Test notes

  • Mark one mail as unread and then read
  • Mark multiple mails as unread and then read
@charlag charlag mentioned this issue Feb 10, 2025
Open
5 tasks
@paw-hub paw-hub self-assigned this Feb 10, 2025
@paw-hub paw-hub linked a pull request Feb 10, 2025 that will close this issue
Use unread state service for marking mails #8512
Merged
paw-hub added a commit that referenced this issue Feb 10, 2025
@paw-hub
Use UnreadMailStateService for marking mails as read/unread
b1a9f79 
This commit moves the service call to MailFacade and adds tests, too.

Closes #8507
@paw-hub paw-hub mentioned this issue Feb 10, 2025
Merged
paw-hub added a commit that referenced this issue Feb 10, 2025
@paw-hub
Use UnreadMailStateService for marking mails as read/unread
ac7fccc 
This commit moves the service call to MailFacade and adds tests, too.

Closes #8507
paw-hub added a commit that referenced this issue Feb 10, 2025
@paw-hub
Use UnreadMailStateService for marking mails as read/unread
ff6de20 
This commit moves the service call to MailFacade and adds tests, too.

Closes #8507
paw-hub added a commit that referenced this issue Feb 10, 2025
@paw-hub
Use UnreadMailStateService for marking mails as read/unread
f1407b8 
This commit moves the service call to MailFacade and adds tests, too.

Closes #8507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paw-hub paw-hub

Labels
feature: conversation view
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use unread state service for marking mails tutao/tutanota
2 participants
@charlag @paw-hub