Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update minSdkVersion to 21 #843

Merged
merged 8 commits into from
Sep 16, 2018
Merged

update minSdkVersion to 21 #843

merged 8 commits into from
Sep 16, 2018

Conversation

connyduck
Copy link
Collaborator

Its actually amazing how many compatibility hacks there where. I hope I found all of them.
And finally: Real elevation shadows for toolbars! 🎉

@connyduck connyduck requested a review from charlag September 10, 2018 07:52
charlag
charlag approved these changes Sep 10, 2018
View reviewed changes
Copy link
Collaborator

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot say that you've found everything but at at least changes seem to be safe
Cannot believe we're actually doing this

@connyduck
Copy link
Collaborator Author

whoops I deleted the wrong drawable files

@connyduck connyduck merged commit 4402f3d into master Sep 16, 2018
@connyduck connyduck mentioned this pull request Sep 16, 2018
Closed
@connyduck connyduck deleted the update_min_api_level branch September 18, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlag charlag charlag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connyduck @charlag