prevent mixup of account timelines #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connyduck
commented
Aug 6, 2024
Comment on lines
+71
to
+82
| @Provides | ||
| @Named("defaultPort") | ||
| fun providesDefaultPort(): Int { | ||
| return 443 | ||
| } | ||
|
|
||
| @Provides | ||
| @Named("defaultScheme") | ||
| fun providesDefaultScheme(): String { | ||
| return "https://" | ||
| } | ||
|
|
There was a problem hiding this comment.
This is kinda weird, but the only way I found to have tests run on a random port without https.
Better ideas very welcome!
There was a problem hiding this comment.
could we provide the whole URL depending on the current account?
Tak
approved these changes
Aug 7, 2024
charlag
reviewed
Aug 10, 2024
charlag
reviewed
Aug 10, 2024
|
Ok, I perf tested this and found no problems. There are a few KBs more memory used, activity start time is the same as before. I fixed a bug where sometimes the wrong api instance was used because the containing object was a Singleton and the api was not recreated after account switching. And I refactored a bit to have less code in the NetworkModule and make the testing simpler. Please have another look. |
Tak
approved these changes
Aug 14, 2024
connyduck
added a commit
that referenced
this pull request
Sep 10, 2024
regression from #4599 https://pug.ninja/@motoridersd/113102603349423738 The problem is, `MediaUploader` is no longer a singleton, so the state is not correctly shared between `ComposeActivity` and `SendStatusService.` But it can't be a singleton, since `MediaUploadApi` (injected into `MediaUploader`) needs to be recreated on account change. Let's share the state in the companion object instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does 2 things:
AccountSwitchInterceptor, the main culprit for the bug. APIs can no longer change their base url after they have been created. As a result they are not Singletons anymore.Here is how I could reliably reproduce the bug:
closes #4567
closes #4554
closes #4402
closes #4148
closes #2663
and possibly #4588