Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix translating boosts in home timeline #4590

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

connyduck
Copy link
Collaborator

fixes #4589

@connyduck connyduck requested review from Tak and charlag July 28, 2024 11:32
Copy link
Collaborator

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why it helps

@connyduck
Copy link
Collaborator Author

We were using the id of the boost to reference its translation status. But it needs to be the id of the boosted post or nothing happens. So I changed it from id to actionableId

@connyduck connyduck merged commit b68e976 into develop Aug 6, 2024
3 checks passed
@connyduck connyduck deleted the fix-translating-boosts branch August 6, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't translate boosts from home timeline
3 participants