override onNewIntent in MainActivity to improve sharing #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating #4517, I found that sharing to Tusky sometimes just does nothing.
This is because when
MainActivityis already open, it isn't always restarted (onCreatenot called) but instead the Intent is delivered toonNewIntentof the existingMainActivity. This fixes the issue by overridingonNewIntent.The problem does not always reproduce, it seems to depend on what is shared from where and on the Android version.
MainActivitymust be open for the problem to occur though.This probably also fixes the issue that sometimes Tusky does not show the right tab when clicking on a notification (#2691)