Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ANR caused by direct message badge #4182

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

connyduck
Copy link
Collaborator

Saw an ANR (app not responding) error being reported in the Play console and then found this. Sorry but runBlocking in production code is an absolute no go.

Copy link
Collaborator

@charlag charlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay from a quick glance, I can't tell if it can lead to any races right now

@connyduck
Copy link
Collaborator Author

tested this again, works fine

@connyduck connyduck merged commit 9781e43 into develop Dec 21, 2023
3 checks passed
@connyduck connyduck deleted the fix_direct_message_badge_anr branch December 21, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants