Write notification account information to the correct account #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use `accountManager.activeAccount` throughout the code. Instead, get the active account once, and use that over the life of the viewmodel. As shown in #3689 (comment) the active account can change before the view model is destroyed, and if that happens account information for the account will be written to the wrong account.
|
Logging (and inspecting the database) shows that this is now writing the data to the correct account. For notifications only -- this doesn't fix the broader data corruption issue, which would be a much more involved PR, and not one I want to tackle during the beta period. There's one comment in |
connyduck
reviewed
May 31, 2023
connyduck
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use
accountManager.activeAccountthroughout the code.Instead, get the active account once, and use that over the life of the viewmodel.
As shown in #3689 (comment) the active account can change before the view model is destroyed, and if that happens account information for the account will be written to the wrong account.