Add support for updating media description and focus point when editing statuses

[Tak]

Completes #3211

We could also add support for viewing them in the edit history view, but I think that will maybe not be super useful since that view is mainly for seeing the history of other people's statuses

Also fixes #3273

[mcclure]

This is currently not even exposed on Mastodon Web. Does this feature exist in the API currently?

I would LOVE this if it's possible because currently if I forget a caption I can't add one after-the-fact.

[Tak]

Yeah, it's in 4.1.0rc1 (see the mastodon PR linked from the linked issue) - I updated my glitch server to a corresponding version to work on this

[sl1txdvd]

I tried this with my Mastodon 4.1.0-rc1 instance and it seems to work. However it shows a message saying there was an error when saving the description ("Fehler beim Speichern der Beschreibung"). As far as I can tell there is no actual error.

[Tak]

That message means that the server reported an error when Tusky sent the update.
Can you describe what you did to get the error?
I've tested:

• Updating the description on an image
• Updating the focus point on an image
• Updating both description and focus point on an image
• Updating the description on a video

[sl1txdvd]

-Start new post, enter text, add image, press "Toot"
-Edit post:
--"Set caption", enter text, press "ok": error says "Failed to set caption"
-"Set focus point", move circle, press "ok": error says "Failed to set focus point"
-Press "Toot"
-Reload post: caption and focus point are the way I set them despite the error messages

Maybe I will find something in the server logs.

[Tak]

Ohh, the message is when setting them locally, that gives me something to look into

[Tak]

Ok, Tusky was attempting to update the media attributes via the normal path as soon as they were accepted, but the server doesn't like that when the post toot has already been published tooted.
I've added a fix, thanks!

[sl1txdvd]

Works nicely now, thanks!

[mcclure]

Tested 49d5a89 on mastodon.social now that it is on v4.1.0rc3

Can confirm it fixes #3273 and fixes the inappropriate "Edit Image" offer. Both focus change and caption change work.

[mcclure]

…even weirder, Tusky 49d5a89 is able to edit focus point on images even though Mastodon Web itself cannot