Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links show too little contrast in dark mode #3477

Closed
1 task done
guerda opened this issue Mar 22, 2023 · 5 comments · Fixed by #3921
Closed
1 task done

Links show too little contrast in dark mode #3477

guerda opened this issue Mar 22, 2023 · 5 comments · Fixed by #3921

Comments

@guerda
Copy link

guerda commented Mar 22, 2023

I am using Tusky daily and I really like this app. What I see as an issue is the dark theme (night theme) in combination with links (hashtags, URLs) etc, as these have too little contrast to be readable in a night time setting.

I tried to figure it out and it seems that the link color is tusky_blue according to

<color name="tusky_blue">#2b90d9</color>
, which translates to #2b90d9
As far as I can see, the background in posts is #282c37 (tusky_grey_20).

According to WebAIM, those two colors have a contrast of 4.04:1 and fails WCAG AAA in both normal and large text.

Bildschirm­foto 2023-03-22 um 09 43 42

I propose to adapt the link color or the background color, to increase the contrast. For example, the link color #83BEF1 would pass all four checks with WebAIM.


  • Tusky Version: 21.0

  • Android Version: 13

  • Android Device: Pixel 7

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@Lakoja
Copy link
Collaborator

Lakoja commented Mar 22, 2023

(Slightly related: #3178

And even more slightly related: #1222 - darker background for example could also solve that partly)

@Lakoja
Copy link
Collaborator

Lakoja commented Mar 30, 2023

(Just for reference: the two blue tints with 4.6 contrast each would be 217aba (for light) and 3c9add (for dark).)

@guerda
Copy link
Author

guerda commented May 6, 2023

Any update on this? I assume it's a question of consideration, not feasibility.

@visualstuart
Copy link

Chiming in, this is an accessibility issue for me. As I understand it, people with cataracts lose some of their ability to perceive blue.

@joergi
Copy link

joergi commented Jan 12, 2024

It's really hard to reading in the app at night in the bedroom.
It would be super helpful, if we can choose the color ourself

connyduck pushed a commit that referenced this issue May 10, 2024
Fixes: #3477

This tweaks two colors: 
* for the dark theme a new slightly darker (timeline) background is
used.
* for the light theme a darker shade of blue is used as highlight color
(`colorPrimary` and `colorSecondary`)

Additional change:
* Use green and red more consistent: use existing colors for the diff
display; move the new light variants to colors.xml like all colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants