Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix digitalocean spaces fetch #507

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Conversation

benitogf
Copy link
Contributor

related to #465

#506

@Acconut
Copy link
Member

Acconut commented Oct 13, 2021

Thank you for this PR, but I don´t think I fully understand its purpose. What was the error from DigitalOcean Spaces? How does this PR fix this and why is the info.Size > 0 check needed?

@benitogf
Copy link
Contributor Author

Hello, the error from DigitalOcean spaces is that it returns NoSuchKey instead of NoSuchUpload on the condition described by the comment above the check when the multipart upload has already been completed or aborted

Will remove the info.Size > 0 check since its already here

if info.Offset == 0 {

Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the explanation and the PR!

@Acconut Acconut merged commit 16a3747 into tus:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants