Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rome to v12 #42

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Mar 31, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rome (source) ^11.0.0 -> ^12.0.0 age adoption passing confidence

Release Notes

rome/tools

v12.0.0

CLI
Breaking changes
  • Review how the traversal of the file system works. Now Rome won't navigate folders that are ignored.
    While this change is a bug fix, this could affect how the ignore entries are defined inside a project. We suggest to review them
    and make sure they still work.
  • --apply-suggested is now called --apply-unsafe
  • rome check --apply and rome check --apply-unsafe exits with non-zero code (error code)
    if there are still diagnostics to be addressed.
Other changes
  • rome check now checks import statements. This is an experimental feature that needs to be
    enabled via configuration. Import can be sorted using rome check --apply-unsafe
  • Rome is able to auto discover the configuration file. If Rome doesn't fine a configuration in the
    working directory, it will try to find one in the parent directories.
  • Add a new global options called --config-path. It tells Rome to try and discover a rome.json file
    in the given path.
    rome format --config-path=../../other/path/
    rome check --config-path=../../other/path/
Configuration
Other changes
  • Rome now uses the internal JSON parser to validate the configuration file. This means Rome won't
    exit anymore if there are issues with the rome.json file, instead it will apply its defaults
    to the sections that are incorrect.
  • Add javascript.organizeImports. This is an experimental feature and users need to opt-in.
{
  "organizeImports": {
    "enabled": true,
    "ignore": ["trickyFile.js"]
  }
}
  • Add linter.rules.all and linter.rules.[group].all. These options allow to enable or disable all
    rules, or all rules for a given group. all and recommended can't be both true.
{
  "linter": {
    "rules": {
      "all": true,
      "style" : {
        "all": false
      }
    }
  }
}

The previous example will enable all rules and disable all rules that belong to the style group.

Editors
Other changes
  • Add support to display diagnostics for JSON files.
  • Add support to format JSON files.
  • Pull diagnostics when parsing a rome.json file.
  • Imports sorting is not applied for files that are not supported or ignored.
Formatter
  • Add support for JSON files
  • Add support for TypeScript 4.7
  • Add support for TypeScript 5.0
Linter

New rules are promoted, please check #​4239 for more
details.

Parser
  • Support for TypeScript 4.7
  • Support for TypeScript 5.0
VSCode
Other changes
  • Add a new option called requireConfiguration. Enabling this option will force Rome to require
    a configuration file in your workspace/project. If Rome doesn't find a rome.json file, it won't
    emit diagnostics.

Configuration

📅 Schedule: Branch creation - "after 1pm and before 5pm on Friday" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@turtton turtton enabled auto-merge (squash) April 3, 2023 04:00
@turtton turtton disabled auto-merge April 3, 2023 04:03
@turtton turtton enabled auto-merge (squash) April 3, 2023 04:06
@renovate
Copy link
Author

renovate bot commented Apr 3, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@turtton turtton merged commit 84edd94 into main Apr 3, 2023
@turtton turtton deleted the renovate/rome-12.x branch April 3, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant