Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add columns required_conversation_resolution and signatures_protected_branch to table github_branch_protection Closes #174, #175 #178

Merged
merged 7 commits into from
Aug 10, 2022

Conversation

karanpopat
Copy link
Contributor

@karanpopat karanpopat commented Jul 28, 2022

Example query results

Results
>select 
    repository_full_name,
    b.name as branch_name,
    signatures_protected_branch
  from 
    github_branch_protection b 
    join github_my_repository r on r.full_name = b.repository_full_name 
    where required_conversation_resolution = true;

+----------------------------------+-------------+----------------------------+
| repository_full_name             | branch_name | signatures_protected_branch|
+----------------------------------+-------------+----------------------------+
| new-testing-org/test-public-repo | main        | false                      |
+----------------------------------+-------------+----------------------------+

> select 
  repository_full_name,
  b.name as branch_name,
  required_conversation_resolution
from 
  github_branch_protection b 
  join github_my_repository r on r.full_name = b.repository_full_name 
  where signatures_protected_branch = true;

+----------------------------------+-------------+----------------------------------+
| repository_full_name             | branch_name | required_conversation_resolution |
+----------------------------------+-------------+----------------------------------+
| new-testing-org/test-public-repo | main        | true                             |
+----------------------------------+-------------+----------------------------------+

@karanpopat karanpopat self-assigned this Jul 28, 2022
@karanpopat karanpopat changed the title Add columns required_conversation_resolution and signatures_protected_branch to table github_branch_protection Add columns required_conversation_resolution and signatures_protected_branch to table github_branch_protection Closes #174, #175 Jul 28, 2022
@rajlearner17 rajlearner17 requested review from LalitLab and removed request for rajlearner17 July 29, 2022 06:56
Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanpopat
left few comments

github/table_github_branch_protection.go Outdated Show resolved Hide resolved
Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format your queries, otherwise looks good

docs/tables/github_branch_protection.md Outdated Show resolved Hide resolved
github/table_github_branch_protection.go Outdated Show resolved Hide resolved
@misraved misraved merged commit 0c6a218 into main Aug 10, 2022
@misraved misraved deleted the issue-175-github_branch_protection branch August 10, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants