Skip to content
This repository was archived by the owner on Sep 25, 2021. It is now read-only.

Adds instructions to README for adding to a Rails app #2

Closed
wants to merge 1 commit into from

Conversation

cannikin
Copy link

@cannikin cannikin commented Jun 1, 2016

I've been including the full turbolinks repo until I found this gem that just includes the final compiled JS, which is probably all that most people need. There weren't any instructions for installing into Rails, so I added some!

@packagethief
Copy link
Member

packagethief commented Jun 1, 2016

Hey @cannikin,

Quickly add Turbolinks to your Rails app without the overhead of coffeescript and building the compiled JS from source

I think there's some confusion, probably because of the Gem name. The turbolinks Gem actually resolves to turbolinks-rails – the Rails engine. turbolinks-rails in turn specifies turbolinks-source as a dependency.

So, you're cool to depend on gem "turbolinks" in your Gemfile. There's no CoffeeScript dependency, and no building from source. It's just the minified JavaScript plus the Rails integration (which you probably want). You shouldn't ever need to depend on turbolinks-source directly.

@cannikin
Copy link
Author

cannikin commented Jun 1, 2016

Ahhhhhhh that explains things then. :) I assumed that the gem turbolinks was from the repo turbolinks with the actual source files and such. So I figured on the first request it was compling the coffeescript into the actual JS that's included by the asset pipeline which seemed like a lot of work if all you needed was the compiled JS to begin with! :)

@cannikin cannikin closed this Jun 1, 2016
@packagethief
Copy link
Member

Yeah, sorry about that. I can see why it would be confusing. I intend to add a README here that at least explains its purpose.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants