Deterministic sorting of search results #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important for reliable tests, e.g. if you are snapshotting views and comparing to reference images.
|
Hey @xaviershay! Thanks for this PR, however when it comes to the core code shared with https://github.com/missive/emoji-mart I prefer porting changes from there as improvements are added. Could you suggest your PR there first? :) |
|
here you go! missive/emoji-mart#343 |
|
@xaviershay great thanks 👍 |
|
@xaviershay sorry, just closed and re-opened this to force a travis ci build. You'll need to run |
|
@xaviershay just published new version to npm with these changes 👌 🚀 |
|
love your work ❤️ 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for reliable tests, e.g. if you are snapshotting views and comparing to reference images.