Explicitly handle undefined result from Array.pop() #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
commented
Oct 10, 2016
| @@ -627,8 +627,11 @@ class ArrayPredictionContext extends PredictionContext { | |||
| let otherWorkList: PredictionContext[] = []; | |||
| selfWorkList.push(this); | |||
| otherWorkList.push(other); | |||
| while (selfWorkList.length > 0) { | |||
| let operands: PredictionContextCache.IdentityCommutativePredictionContextOperands = new PredictionContextCache.IdentityCommutativePredictionContextOperands(selfWorkList.pop(), otherWorkList.pop()); | |||
| for (let currentSelf = selfWorkList.pop(), currentOther = otherWorkList.pop(); | |||
There was a problem hiding this comment.
❓ Is the following style easier to read?
while (true) {
let currentSelf = selfWorkList.pop();
let currentOther = otherWorkList.pop();
if (!currentSelf || !currentOther) {
break;
}
let operands...
There was a problem hiding this comment.
Yes, I think the while seems easier to comprehend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request corrects two cases where the result of calling
pop()is being treated asT | undefined, by updating the code so the compiler recognizes that the value is actually known to beT.📝 Strict null checks are currently disabled, but we're working to change that. See #26.