Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CORS issue while fetch assets #152

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

igobranco
Copy link
Contributor

Fix CORS issue when fetching asset, because of incorrect credentials property value, changed from include to same-origin. #151

Fix CORS issue when fetching asset, because of incorrect credentials
property value, changed from include to same-origin.
tunapanda#151
@GuiLeme
Copy link

GuiLeme commented Mar 26, 2024

Hello, Guys, I would like to know the status of this PR? Is this planned to be merged? I am really interested!

@igobranco
Copy link
Contributor Author

@0xMurage I have to do something more to make this PR to be merged? The CI didn't start when I created this PR.

@0xMurage 0xMurage self-requested a review July 16, 2024 22:14
Copy link
Collaborator

@0xMurage 0xMurage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT!

@0xMurage 0xMurage merged commit 4159a02 into tunapanda:master Jul 16, 2024
Copy link

🎉 This PR is included in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants