nusb: retry control request on stall #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed 'endpoint 0x00: status 0xe0005000 (pipe stalled)' in macOS `log` nusb profiler. Reading docs, appear this is not unusual and one should `claim_interface` and `clear_halt`. Seems to resolve; thought the messages will still be present in `log` as will be on second attempt. I started digging into this due to Facedancer panicing on device side with 'usb1.USBErrorTimeout: LIBUSB_ERROR_TIMEOUT [-7]'. With `--F=libusb` this did not happen. Appears it is with read of Debug descriptor specifically so have added claim interface to `ControlRequest` on macOS for this - was not an issue on Linux. Tools used: `log | ag 'IOUSB'` and Cynthion/Facedancer.
tuna-f1sh
force-pushed
the
stall_retry
branch
from
0510711 to
d65da21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed 'endpoint 0x00: status 0xe0005000 (pipe stalled)' in macOS
lognusb profiler. Reading docs, appear this is not unusual and one shouldclaim_interfaceandclear_halt. Seems to resolve; though the messages will still be present inlogas will be on second attempt.I started digging into this due to Facedancer panicing on device side with 'usb1.USBErrorTimeout: LIBUSB_ERROR_TIMEOUT [-7]'. With
--F=libusbthis did not happen. Appears it is with read of Debug descriptor specifically so have added claim interface toControlRequeston macOS for this - was not an issue on Linux.Tools used:
log | ag 'IOUSB'and Cynthion/Facedancer.