Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipmi pool api #554

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Fix ipmi pool api #554

merged 2 commits into from
Jun 8, 2017

Commits on Jun 2, 2017

  1. Fix IPMI Pool API 

    I messed this up somehow ever though I checked it a ton of times. Not sure
how i missed this but I have since learned pattern matching on scala sets
is not that simple. This correctly matches against Sets and non sets. I
updated the test to check for the case of two pools being returned since it
additionally checks for the case that one pool can be returned.

I spend far too much time trying to get different configs to work with the tests
I had some luck using FakeApplication and setting some additionalConfig for it.
However it turns out that if you have two tests using fake config and they are
both different only the first test that runs fake config takes effect and it applies
to all the other runs...
    @michaeljs1990
    michaeljs1990 committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    9fbb86a View commit details
    Browse the repository at this point in the history

  2. Cleanup Dead Code 

    Cleanup dead code and also refactor Set check to remove warning about type
erasure when matching against a set.
    @michaeljs1990
    michaeljs1990 committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    f149964 View commit details
    Browse the repository at this point in the history