Trying to revive the tests #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xargs breaks when find doesn't return anything. While there is the -r flag for that, just using -delete makes more sense.
|
👍 |
|
I think this is a good start. This is still failing though: RUN_RUBY=true RUN_SCALA=false GEM_NAME=collins-state Could use some help fixing this. Did it ever worked? If so, I can try git-bisect'ing to found what broke it. |
|
@Primer42 can we get this merged? Or even better, somehow figure out how to get those things merged quicker in the future? |
|
LGTM |
|
@Primer42 Then go merge it! :) Is there even another maintainer active? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #483