Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway add type hints #25

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Gateway add type hints #25

wants to merge 19 commits into from

Conversation

patrickjaigner
Copy link
Contributor

No description provided.

@larsfroelich
Copy link
Collaborator

Looks great! happy to have type hinting + checking in the gateway.
However, this PR also contains controller-related changes, and some whitespace/formatting changes are undesirable (see e.g. the docker-run command)
I'll improve it and merge

@patrickjaigner
Copy link
Contributor Author

Sounds good. I realized too late that I branched from my integration branch instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsfroelich larsfroelich Awaiting requested review from larsfroelich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickjaigner @larsfroelich