Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix right-side bar hrefs in docs #530

Closed
wants to merge 1 commit into from

Conversation

pedroscaff
Copy link

The hrefs with & still don't work properly, but it is an issue with https://github.com/facebook/docusaurus, I will report it there and post it here.

@pedroscaff
Copy link
Author

facebook/docusaurus#1877

@Nevon
Copy link
Collaborator

Nevon commented Oct 24, 2019

Thanks for reporting the issue to docusaurus! ❤️ I won't merge this PR, however, as we intentionally create our own anchor links. The reason is that we ship references to the documentation as part of KafkaJS' error messages, which means that we need the links to never change, even if we end up changing the title or Docusaurus changes the way they generate anchors.

@Nevon Nevon closed this Oct 24, 2019
@pedroscaff
Copy link
Author

Do you think that is the best way to do it? I think breaking the documentation navigation is not a good solution for the issue. Docusaurus generates the anchors as we would expect (bugs aside hehe), so we could stick to what they generate.

@Nevon
Copy link
Collaborator

Nevon commented Oct 28, 2019

I think breaking the documentation navigation is not a good solution for the issue.

No, of course, we don't want the sidebar nav to break either. I think facebook/docusaurus#561 is the correct solution.

Maybe a workaround could be to generate the anchor via Docusaurus and also have our own stable anchor. That way the links in error messages keep working, while the sidebar nav also works, even if they link to different anchors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants