Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : s3 url 수정 #248

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix : s3 url 수정 #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .../java/site/timecapsulearchive/core/infra/notification/data/mapper/NotificationMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,12 @@
import org.springframework.stereotype.Component;
import site.timecapsulearchive.core.domain.capsuleskin.data.dto.CapsuleSkinCreateDto;
import site.timecapsulearchive.core.infra.notification.data.dto.request.CreatedCapsuleSkinNotificationRequest;
import site.timecapsulearchive.core.infra.s3.manager.S3PreSignedUrlManager;
import site.timecapsulearchive.core.infra.s3.manager.S3UrlGenerator;

@Component
@RequiredArgsConstructor
public class NotificationMapper {

private final S3PreSignedUrlManager s3PreSignedUrlManager;
private final S3UrlGenerator s3UrlGenerator;

public CreatedCapsuleSkinNotificationRequest toRequest(Long memberId,
Expand All @@ -22,9 +20,7 @@ public CreatedCapsuleSkinNotificationRequest toRequest(Long memberId,
dto.skinName(),
"캡슐 스킨 생성이 완료되었습니다",
dto.skinName() + "이 생성되었습니다. ARchive에서 확인해보세요!",
s3PreSignedUrlManager.getS3PreSignedUrlForGet(
s3UrlGenerator.generateFileName(memberId, dto.directory(), dto.skinName())
)
s3UrlGenerator.generateFileName(memberId, dto.directory(), dto.skinName())
);
}
}
Loading