Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nest可自定义 #314

Merged
merged 4 commits into from
Aug 6, 2017
Merged

nest可自定义 #314

merged 4 commits into from
Aug 6, 2017

Conversation

0x2CA
Copy link

@0x2CA 0x2CA commented Aug 6, 2017

No description provided.

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

_config.yml中设置那一块感觉有点繁琐哦,能否想办法精简成只需要设置一个true/false值?

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

这个是支持true false,也可以自定义

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

我的意思是,能否在设置成true之后(只需要设置1次),若不填写参数就用默认值,若填写了参数就用自定义值呢?

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

直接设置canvas_nest: true就是默认样式,
canvas_nest:
enable: true
count: "60" 这样就多数量进行自定义

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

这个就是你所说的

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

当然enable:设置看起来有点多余,但是应该严谨一点

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

如果enable设置成true之后,canvas_nest之后就不能填东西了是吧?

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

现在改了,现在不需要设置enable,
当然不能填东西,因为自定义,canvas_nest就是一个对象了,自定义都是它的属性

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

还有一个问题,script代码可以放在after_footer.jade中。

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

请问一下gitment和canvas下面的选项必须先用#注释掉吗?如果没有注释掉(但空着)且上面写的是false会有什么影响不?

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

不影响,如果是false,if处就结束了,不影响

@tufu9441 tufu9441 merged commit 77adc74 into tufu9441:master Aug 6, 2017
@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

额,,,那个影响

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

那个,如果填了true,gitment就是变量,但是如果下面写成对象属性赋值的会报错

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

我的意思是填了false,但下面空着不填,会出错不?

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

这个是语法错误

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

不会,如果是false下面可以不写,但是一定要注释掉

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

呃……我的意思就是在不注释掉的情况下啊😂
因为注释掉了的话使用的时候还需要手动去掉注释,不能直接填了就用~

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

额。。懂我意思吗

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

如果你需要这个要求,那么需要宁外一个变量,就是多起一个gitment_var

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

喔,好像越搞越复杂了😂

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

分别管理,gitment管理启用,gitment_var管理属性,当然我觉得还不如直接enable

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

那我改回enable形式吧

@0x2CA
Copy link
Author

0x2CA commented Aug 6, 2017

那个gitment采用enable ,canvas就不用enable吧

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

您决定吧,尽可能简单而人性化就好~

@tufu9441
Copy link
Owner

tufu9441 commented Aug 6, 2017

那您得重新提交一个PR了

@tufu9441
Copy link
Owner

tufu9441 commented Aug 8, 2017

我测试了一下nest,是不是canvas_nest之后不能填true/false(因为我不管填什么都会报错)?而下面的enable如果填了false就是不启用,填了true但不填参数是默认效果,填了true且填了参数是自定义效果。是这样的吗?但是我记得你之前说的是上面的也要填,所以有些疑惑。

@tufu9441
Copy link
Owner

tufu9441 commented Aug 8, 2017

那如果这样的话判断条件是否可以简化成:

if theme.canvas_nest.enable == true

@tufu9441
Copy link
Owner

tufu9441 commented Aug 8, 2017

另外我觉得是否启用gitment的判断条件也可以简化成:

if theme.gitment.enable == true

@0x2CA
Copy link
Author

0x2CA commented Aug 8, 2017

是可以在上方写true /false,但是需要把下面注释掉

@tufu9441
Copy link
Owner

tufu9441 commented Aug 8, 2017

原来如此,那可能就是因为我下面没有注释掉所以出错了……那你看我说的这种方案是否可行?上面就完全不填了,反正下面参数留空就是默认效果。

@Lee981265
Copy link

image
canvas_nest 不生效

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants