Fix Linux 5.18 #18
Open
Fix Linux 5.18 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous kernel version provided the current CPU inside of task_struct directly. This is not the case anymore, and the current CPU has to be extracted by using information from thread_info, which is only provided if CONFIG_THREAD_INFO_IN_TASK is enabled in the kernel config. Builds without CONFIG_THREAD_INFO_IN_TASK will be aborted. Note: I am not confident that this is the complete and correct solution, however the most practical one. (I.e. feel free to overrule it down the road)
The previously used functions get_online_cpus() and put_online_cpus() have been removed in 8c854303ce0e38e5bbedd725ff39da7e235865d8. As both functions where pure aliases they are replaced with the calls they were previously pointing to, cpus_read_lock() and cpus_read_unlock().
The driver module depends on the definition module. dkms offer the variable BUILD_DEPENDS for that, even if it notes that it is not necessarily enforced this should be used to avoid build failures.
In Linux kernel commit 39808e451fdf ("kbuild: do not read
$(KBUILD_EXTMOD)/Module.symvers") the in x86_adapt used way of communicating
dependencies for symbols of other modules has been updated.
This commit applies this new method to the x86_adapt_driver module by
setting the variable KBUILD_EXTRA_SYMBOLS in the make file.
The previous version used shell globbing to find files, which also returned directories which failed in the subsequent call to sed. The fix is to search for files only using `find DIR -type f` and apply sed only to these found files.
rschoene
reviewed
Oct 18, 2022
rschoene
reviewed
Oct 18, 2022
| @@ -1551,11 +1551,11 @@ static int __init x86_adapt_init(void) | |||
| { | |||
| int i,err; | |||
|
|
|||
| get_online_cpus(); | |||
| cpus_read_lock(); | |||
There was a problem hiding this comment.
is this avail. for older Linuxes? Since when? Also check unlock
There was a problem hiding this comment.
Introduced in 8f553c498e17, first released in Linux 4.13.
In theory, yes. Furthermore, as far as I understand the implementation, this still requires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes two deprecated calls into the kernel to their updated versions.
Breaks compatibility to kernels with
CONFIG_THREAD_INFO_IN_TASKdisabled.(This is checked and a CPP
#erroris created if this is the case.)