Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Registry on HttpMetricsLayerBuilder #139

Closed
wants to merge 1 commit into from

Conversation

kennedyoliveira
Copy link

Adding option to allow setting a custom prometheus registry, so it can hook into other places using prometheus directly.

@ttys3
Copy link
Owner

ttys3 commented Dec 6, 2024

Thank you for your PR.

I am currently refactoring this crate. Since the otel rust no longer recommends using the pull mode exporter, I am planning to remove the built-in convenient support from this crate. However, users can still add the Prometheus export by themselves. This approach is more flexible and allows the crate itself to focus more on its own functionality.

@ttys3
Copy link
Owner

ttys3 commented Dec 10, 2024

since v0.9.1, you can use a custom prom registry now.
please see https://docs.rs/axum-otel-metrics/0.9.1/axum_otel_metrics/index.html#advanced-usage

@ttys3 ttys3 closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants