Promise doesn't get rejected

[remmycat]

Hey, I just noticed that twit seems to not reject a promise when, for example, the rate limit exceeded in a get request. Instead it just resolves the promise and has the error(s) as an array in the result.data.
I'm not sure if it's intended like that but I expected it to reject the promise when I don't get the data I requested (my promise chain should break when that happens).

[richardkazuomiller]

I also think errors should reject the promise! (^^♪

[Chandler]

Hey @remhume, I opened a PR #297 before I realized you already had one open. If they go with yours maybe you can at least make good use of my unit test : )

[stuartpb]

Yeah, this is just straight-up a bug in the promise implementation. #297 fixes it correctly - I would merge that in to fix it (and close #285 without merging).

[Chandler]

@stuartpb nice, who do we need to ping to get it merged?

[dandv]

Thanks everyone for showing demand for rejecting on errors. twitter-lite has also implemented this behavior.