feat: adding support for os/arch agnostic manifest url for plugin install #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarreira
requested changes
Nov 1, 2022
GabhenDM
force-pushed
the
add-plugin-manifest-install
branch
from
98bc890 to
32e992d
Compare
GabhenDM
force-pushed
the
add-plugin-manifest-install
branch
from
32e992d to
4fb0d23
Compare
tcarreira
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
This PR aims to introduce support for os/architecture agnostic manifest URL for plugin installation. It will utilize the GOOS and GOARCH variables in order to find the correspondent URL in order to download the plugin.
It also utilizes the Content-Type from the response in order to identify if it's a manifest file or an actual binary. Also added a validation to avoid infinite recursive calls.
Unsure if this implementation works with plugin bundle install, but believe it would.
Added a single unit test for a plugin install utilizing manifest file, feel free to suggest new cases to test, wanted to get a first input beforehand :)