Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Niconico playlist format #1

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

viliml
Copy link

@viliml viliml commented Sep 8, 2020

I used pages since niconico has native support for them and requests for more than 200 videos at once sometimes fail.
I didn't bother with submitting a PR to the original repo since there's no point in trying to download a playlist if every video fails many times because of the lack of heartbeat.
I am the original author of this code and I am willing to release it under Unlicense.

@tsukumijima
Copy link
Owner

Thank you for the pull request! (I'm sorry I was late to notice)
I knew that Nico Nico's My Page was renewed, but I didn't know that the format of My List had changed.
I haven't tested this code yet, but it doesn't seem to be a problem, so I'd like to merge it once.
If there is any problem, I would like to fix it in the future.
(Since we are using translation, the sentence may be unnatural)

@tsukumijima tsukumijima merged commit 40c3589 into tsukumijima:fix/niconico Sep 20, 2020
tsukumijima added a commit that referenced this pull request Sep 20, 2020
Update to new Niconico playlist format
@viliml viliml deleted the patch-2 branch December 3, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants