-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak support #347
Flatpak support #347
Conversation
If tsukimi/.github/workflows/build_windows.yml Line 119 in a8bb4e6
tsukimi/.github/workflows/build_release.yml Line 103 in a8bb4e6
|
Thanks for your PR! Looks like Ive overlooked many things, sorry about that.
Domain |
It's showing a 404 GitHub page now. |
* currently the build is working locally using a fork of upstream
oh, there is a little issue. and now? |
* automatic version checking with x-checker-data
This pull request is now considered ready for review. The manifest repo is hosted at: https://github.com/caesarw/flathub/tree/tsukimi-submission. To run a test build locally before merging, you need to do the following:
These steps are required for a successful build because this pull request has not yet been merged. Once it's merged, no modifications to the manifest are needed. |
Signed-off-by: tsukinaha <sakuovds@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works pretty well overall.
I just fixed some i18n issues that were caused by the app itself. But it looks like the app icon is broken in app. Do you have any idea?
* fixed issues with FFmpeg extension * fixed about dialog icon missing
Fixed in |
Signed-off-by: tsukinaha <sakuovds@gmail.com>
LGTM, I think we are ready to merge |
Merged, thank you! |
Yes. You can track the progress here. |
The submission got delayed because there has been an issue on linking at the very end of compilation of Specifically, the LLVM linker was able to find libmpv when gst was manually compiled and installed in the current version of the manifest; however, when the manually compiled gst was removed and switched to the gst that's built into the Any help will be appreciated. Update: fixed it. I'll open a new pull request when the patch is ready. |
This pull request adds Flatpak packaging to the project (closes #184). Currently, the build works locally on my branch (which comes with fixes for desktop entry and metadata files).
Changelog
Testing
To build it locally, first install
flatpak-builder
, then run the builder:This will build the package, export it to local repo in folder
repo
, and install it in your local Flatpak installation.To run linter on the manifest, first install
org.flatpak.Builder
with Flatpak, then run the linter:Todos
tsuna.moe
so that it does not result in a521
. During Flathub submission process, the Flatpak manifest linter will automatically detect the accessibility of the domain name to ensure the domain name belongs to the project maintainer, and a521
status will make it think that the domain name is not accessible.(WIP) Update the current GitHub Actions workflows to push updates to Flathub manifest repo automatically (mainly for generating cargo sources).The manifest repo will automatically regenerate Cargo sources when a tag is released from the upstream.