html: upgrade to xterm 5.4.0 #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsl0922 Can you please trigger the workflow. |
|
This upgrade is necessary as this will be followed by a pull request to add Unicode 11 support. This will significantly improve displaying of emojis. https://github.com/mikelorant/ttyd/commit/6ab15260575940289ca4a5365e050a39a634015f |
Upgrade xterm.js to the latest stable release. As part of this upgrade, the xterm packages have been scoped as the unscoped packages were not updated. The addons have also been upgraded to match the compatible versions. As part of this upgrade, a compatibility issue was identified with the Gulp task to inline source. By disabling compression, this allowed the task to complete successfully. The size of the source file `html.h` did not change significantly which indicates compression was not being applied previously. Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
|
@tsl0922 Lint warnings have been resolved. |
|
@tsl0922 Thanks for merging this so promptly! I have one more pull request I will put up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade xterm.js to the latest stable release.
As part of this upgrade, the xterm packages have been scoped as the unscoped packages were not updated.
The addons have also been upgraded to match the compatible versions.
As part of this upgrade, a compatibility issue was identified with the Gulp task to inline source. By disabling compression, this allowed the task to complete successfully. The size of the source file
html.hdid not change significantly which indicates compression was not being applied previously.