Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code completion with replacing characters to the right #30

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

tshino
Copy link
Owner

@tshino tshino commented Jan 4, 2022

Reproducing steps:

  1. open package.json
  2. place the cursor inside contributes.commands section
  3. type "
  4. automatically get the closing " inserted
  5. automatically get a suggestion category": " (the key depends on the context) inside the two quotes.
  6. hit TAB to accept the suggestion
  7. get resulted text "category", ""
  8. record the above sequence from 2 to 7 and then try playback at another location.

This type of code completion replaces the quotes "" surrounding the cursor with the suggested text.
Detecting this type of code completion is not supported in the current implementation of TypingDetector.
This PR adds the capability of detecting that type of code completion to fix the issue.

@tshino tshino merged commit 7419c36 into main Jan 4, 2022
@tshino tshino deleted the fix-code-completion-with-delete-right branch January 4, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant