Add reentrantGuard.callExclusively() #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the implementation of Background recording API #176.
To provide APIs for this extension and make them provide reasonable guarantees for their functionalities, they should not fail regardless of whether the user is interacting with this extension at the moment the API is invoked by other extensions.
For example, #176 will provide a new API to enable/disable background recording mode. The mode should not change during any execution of wrapper or playback commands to avoid generating an inconsistent internal state of the keystroke recording mechanism. As a solution to these requirements, this PR introduces
reentrantGuard.callExclusively().