[DO NOT MERGE] Add debug logs to write_eeprom #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprital
reviewed
Dec 23, 2024
| @@ -528,12 +529,31 @@ def write_eeprom(self, offset, num_bytes, write_buffer): | |||
| Example: | |||
| mlxreg -d /dev/mst/mt52100_pciconf0 --reg_name MCIA --indexes slot_index=0,module=1,device_address=154,page_number=5,i2c_device_address=0x50,size=1,bank_number=0 --set dword[0]=0x01000000 -y | |||
| """ | |||
|
|
|||
| logger.log_error(f'--- err:-5_debug --- Entered write_eeprom()') | |||
There was a problem hiding this comment.
having LOG ERR add ERR message to LOG. You should change it to NOTICE\INFO
dprital
reviewed
Dec 23, 2024
| else: | ||
| stack_trace.append(f"{func_name}()") | ||
| execution_flow = " --> ".join(reversed(stack_trace)) | ||
| logger.log_error(f'--- err:-5_debug --- Call Stack: {execution_flow}') |
There was a problem hiding this comment.
having LOG ERR add ERR message to LOG. You should change it to NOTICE\INFO
dprital
reviewed
Dec 23, 2024
| if num_bytes != len(write_buffer): | ||
| logger.log_error("Error mismatch between buffer length and number of bytes to be written") | ||
| return False | ||
|
|
||
| while num_bytes > 0: | ||
| page_num, page, page_offset = self._get_page_and_page_offset(offset) | ||
| logger.log_error(f'--- err:-5_debug --- Attempt to write to: page={page}, offset={page_offset}') |
There was a problem hiding this comment.
having LOG ERR add ERR message to LOG. You should change it to NOTICE\INFO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To debug the 'err:-5' issue. Need to understand whether this error log appears as a result of a read eeprom operation (which in that case, can be ignored), or due to a write operation (needs to be handled).
Work item tracking
How I did it
Added logs.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)