Fix 0.27 test failures in 002_icpp.t #33
Open
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @johannessen All tests now pass with Strawberry Perl. Tested with 5.36 and 5.40 releases. |
|
The new section on C++ in the ongoing rewrite of perlxs recommends ExtUtils::CppGuess “for portability in production use”. But, as of now, bugs in test files cause this module to fail to install cleanly on several platforms, which effectively makes XS modules less portable if they rely on ExtUtils::CppGuess. @mohawk2 @tsee Could you please review, merge, and release this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #31 by skipping the affected tests on macOS only.
I think this patch will also resolve the problem with the mocking described in #30 and #32, but I don’t have access to one of the platforms that apparently are affected.
@shawnlaffan would you mind verifying this on Strawberry, please?