fix(socketio): add support for ack callbacks

closes #2679
tsedio · Apr 25, 2024 · d7880a9 · d7880a9
1 parent 64181a1
commit d7880a9
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 8 deletions.
diff --git a/packages/third-parties/socketio/src/class/SocketHandlersBuilder.spec.ts b/packages/third-parties/socketio/src/class/SocketHandlersBuilder.spec.ts
@@ -772,7 +772,7 @@ describe("SocketHandlersBuilder", () => {
     });
   });
   describe("deserialize()", () => {
-    it("should call ConverterService.deserialize", () => {
+    it("should call deserialize on args", () => {
       const provider: any = {
         store: {
           get: jest.fn()
@@ -800,5 +800,34 @@ describe("SocketHandlersBuilder", () => {
         args: [["any"]]
       });
     });
+
+    it("should map ack callback without deserialization", () => {
+      const provider: any = {
+        store: {
+          get: jest.fn()
+        }
+      };
+      const parameters: any[] = [
+        {
+          filter: SocketFilters.ARGS,
+          useMapper: true,
+          mapIndex: 0,
+          type: Function
+        }
+      ];
+      const ack = () => {};
+      const scope: any = {
+        args: [ack]
+      };
+
+      const builder = new SocketHandlersBuilder(provider, PlatformTest.injector);
+
+      // @ts-ignore
+      builder.deserialize({parameters} as any, scope as any);
+
+      expect(scope).toEqual({
+        args: [ack]
+      });
+    });
   });
 });
diff --git a/packages/third-parties/socketio/src/class/SocketHandlersBuilder.ts b/packages/third-parties/socketio/src/class/SocketHandlersBuilder.ts
@@ -18,7 +18,10 @@ import {SocketSessionData} from "./SocketSessionData";
 export class SocketHandlersBuilder {
   private readonly socketProviderMetadata: SocketProviderMetadata;
 
-  constructor(private provider: Provider, private injector: InjectorService) {
+  constructor(
+    private provider: Provider,
+    private injector: InjectorService
+  ) {
     this.socketProviderMetadata = new SocketProviderMetadata(this.provider.store.get("socketIO"));
   }
 
@@ -161,12 +164,14 @@ export class SocketHandlersBuilder {
       const {filter, useMapper, mapIndex, type, collectionType} = parameters![index];
       let value = scope.args[mapIndex!];
 
-      if (filter === SocketFilters.ARGS && useMapper) {
-        value = deserialize(value, {
-          type,
-          collectionType,
-          useAlias: true
-        });
+      if (filter === SocketFilters.ARGS) {
+        if (useMapper && typeof value !== "function") {
+          value = deserialize(value, {
+            type,
+            collectionType,
+            useAlias: true
+          });
+        }
         scope.args[mapIndex!] = value;
       }
     });