Revert "fix(react-formio): Fix Form about onSubmit & onSubmitDone eve…

…nts"
tsedio · Nov 17, 2021 · 9ce6c29 · 9ce6c29
1 parent 47929b7
commit 9ce6c29
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/packages/config/craco.config.js b/packages/config/craco.config.js
@@ -29,7 +29,7 @@ module.exports = {
       ],
       coverageThreshold: {
         global: {
-          branches: 35.73,
+          branches: 36.53,
           functions: 51.76,
           lines: 50.49,
           statements: 50.91,

diff --git a/packages/react-formio/src/components/form/useForm.hook.ts b/packages/react-formio/src/components/form/useForm.hook.ts
@@ -96,13 +96,15 @@ export const useForm = (props: any): any => {
   }, [src]);
 
   useEffect(() => {
-    props.onSubmit && events.current.set("onSubmit", props.onSubmit);
-  }, [props.onSubmit, events]);
+    if (form) {
+      createWebForm(form, options);
+    }
 
-  useEffect(() => {
-    props.onSubmitDone &&
-      events.current.set("onSubmitDone", props.onSubmitDone);
-  }, [props.onSubmitDone, events]);
+    return () => {
+      isLoaded.current = false;
+      instance.current && instance.current.destroy(true);
+    };
+  }, []);
 
   return {
     element