Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Javadoc from method body to method declaration (visualization problem) #791

Closed
tsantalis opened this issue Oct 21, 2024 · 4 comments
Closed

Moved Javadoc from method body to method declaration (visualization problem) #791

tsantalis opened this issue Oct 21, 2024 · 4 comments
Assignees
@tsantalis @pouryafard75

Comments

@tsantalis
Copy link
Owner

Defects4J dataset: Closure 148
L376-387 with R427-429, R437-439 and R446-449

image
@tsantalis tsantalis self-assigned this Oct 21, 2024
@pouryafard75
Copy link
Collaborator

pouryafard75 commented Nov 27, 2024 •
edited
Loading

@tsantalis
(Unrelated to this issue), In this case, the multi-mapping for the comment, is not correct.

Screenshot 2024-11-26 at 10 19 54 PM

@pouryafard75
Copy link
Collaborator

pouryafard75 commented Nov 27, 2024 •
edited
Loading

@tsantalis The javadocs on the left handside, are actually not javadocs, according to our definition. They are not attached to a program element, and we consider the non attached javadocs as comments (we had this discussion here in detail GumTreeDiff/gumtree#368 (comment)). So if we are willing to fix this, I have to submit a PR to GumTree to change the visitor.
I let you decide this one. You can close it if you find it unncessary. (Btw, the comments are problematic as I reported in the previous message. #791 (comment)

@pouryafard75
Copy link
Collaborator

image

pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue Nov 27, 2024
@pouryafard75
ASTDiff: Fix for tsantalis#791
4e25686
pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue Nov 27, 2024
@pouryafard75
ASTDiff: Fix for tsantalis#791
4de3bed
pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue Nov 27, 2024
@pouryafard75
ASTDiff: Fix for tsantalis#791
3f2013a
tsantalis pushed a commit that referenced this issue Nov 27, 2024
@pouryafard75 @tsantalis
ASTDiff: Fix for #791
7f1b5a9
@tsantalis
Copy link
Owner Author

Fix matching of comments in Closure 148
src_com_google_javascript_jscomp_PeepholeFoldConstants.java

image

tsantalis added a commit that referenced this issue Nov 27, 2024
@tsantalis
Fix incorrect duplicate group-comment mappings (issue #791)
ffe2080 
Defects4J dataset: Closure 148
src_com_google_javascript_jscomp_PeepholeFoldConstants.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsantalis tsantalis

@pouryafard75 pouryafard75

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsantalis @pouryafard75