Fix controllers not popping when pressing a tab bar button #53
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // | ||
| // RootTabBarController.swift | ||
| // trySwift | ||
| // | ||
| // Created by Sash Zats on 3/2/18. | ||
| // Copyright © 2018 NatashaTheRobot. All rights reserved. | ||
| // | ||
|
|
||
| import UIKit | ||
|
|
||
| class RootTabBarController: UITabBarController, UITabBarControllerDelegate { | ||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| self.delegate = self | ||
| } | ||
|
|
||
| func tabBarController(_ tabBarController: UITabBarController, didSelect viewController: UIViewController) { | ||
| guard | ||
| let splitViewController = viewController as? UISplitViewController, | ||
| let navigationController = splitViewController.viewControllers.last as? UINavigationController | ||
| else { | ||
| return | ||
| } | ||
|
|
||
| // if several view controllers are in the stack, pop to the root | ||
| if navigationController.viewControllers.count > 1 { | ||
| navigationController.popToRootViewController(animated: true) | ||
| } else { | ||
| // if there's at least one view controller in the stack (which there always should be) | ||
| if let firstController = navigationController.viewControllers.first { | ||
| // we either delegate to the controller since it knows better how to scroll to the top | ||
| if let scrollableToTop = firstController as? ScrollableToTop { | ||
| scrollableToTop.scrollAfterTabTap() | ||
| // or we find the topmost scroll view and scroll it to the top | ||
| } else { | ||
| firstController.view.findScrollSubview()?.setContentOffset(.zero, animated: true) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| protocol ScrollableToTop { | ||
| func scrollAfterTabTap() | ||
| } | ||
|
|
||
| private extension UIView { | ||
| func findScrollSubview() -> UIScrollView? { | ||
| if let scrollView = self as? UIScrollView, | ||
| scrollView.contentSize.width < scrollView.contentSize.height { | ||
| return scrollView | ||
| } | ||
| for subview in self.subviews { | ||
| if let scrollView = subview.findScrollSubview(), | ||
| scrollView.contentSize.width < scrollView.contentSize.height { | ||
| return scrollView | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this since it's handled at a higher level now (RootTabBarController delegates this functionality via protocol conformance now)