Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'Add to home screen' option to Preset's context menu #425

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

ashutoshgngwr
Copy link
Member

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #425 (f30d243) into master (2fe643b) will increase coverage by 0.22%.
The diff coverage is 82.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   85.16%   85.39%   +0.22%     
==========================================
  Files          30       32       +2     
  Lines        1726     1780      +54     
  Branches      220      227       +7     
==========================================
+ Hits         1470     1520      +50     
  Misses        119      119              
- Partials      137      141       +4     
Flag Coverage Δ
android 84.63% <82.69%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 86.11% <33.33%> (ø)
...m/github/ashutoshgngwr/noice/WakeUpTimerManager.kt 71.05% <60.00%> (-3.95%) ⬇️
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 76.00% <66.66%> (+1.80%) ⬆️
...shutoshgngwr/noice/fragment/WakeUpTimerFragment.kt 62.90% <70.58%> (+1.88%) ⬆️
...hub/ashutoshgngwr/noice/ShortcutHandlerActivity.kt 84.21% <84.21%> (ø)
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 92.72% <89.74%> (-0.13%) ⬇️
...hub/ashutoshgngwr/noice/fragment/PresetFragment.kt 81.81% <93.33%> (+2.74%) ⬆️
...java/com/github/ashutoshgngwr/noice/Application.kt 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe643b...f30d243. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit eef61a0 into master Dec 3, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/preset/add-to-home-screen branch December 3, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant