Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Maintenance #311

Merged
merged 4 commits into from
Sep 1, 2020
Merged

General Maintenance #311

merged 4 commits into from
Sep 1, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Replace SeekBar with Sliders (displays value using ToolTips while sliding the thumb) in SoundLibraryFragment
  • Add an informative message if the list is empty when selecting a preset in WakeUpTimerFragment
  • Increase time period range (5 mins was too less)

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@ashutoshgngwr ashutoshgngwr added this to the 0.10.x milestone Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #311 into master will increase coverage by 0.04%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   85.71%   85.76%   +0.04%     
==========================================
  Files          29       29              
  Lines        1505     1510       +5     
  Branches      176      177       +1     
==========================================
+ Hits         1290     1295       +5     
  Misses        115      115              
  Partials      100      100              
Flag Coverage Δ
#android 84.88% <96.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 78.04% <ø> (ø)
.../github/ashutoshgngwr/noice/sound/player/Player.kt 92.10% <ø> (ø)
...hutoshgngwr/noice/fragment/SoundLibraryFragment.kt 87.73% <94.44%> (+0.23%) ⬆️
...shutoshgngwr/noice/fragment/WakeUpTimerFragment.kt 80.35% <100.00%> (+1.11%) ⬆️
...ub/ashutoshgngwr/noice/cast/CastOptionsProvider.kt 85.71% <100.00%> (ø)
cast-receiver/src/library.mock.ts 100.00% <0.00%> (ø)
cast-receiver/src/status_ui_handler.ts 97.43% <0.00%> (ø)
cast-receiver/src/player_manager.ts 94.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37dd80...7c99dd0. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit a4c08db into master Sep 1, 2020
@ashutoshgngwr ashutoshgngwr deleted the chore/general-maintenance branch September 1, 2020 18:41
@ashutoshgngwr ashutoshgngwr mentioned this pull request Sep 4, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant