Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds play-pause toggle menu item to MainActivity #198

Merged
merged 4 commits into from
Jun 15, 2020

Conversation

ashutoshgngwr
Copy link
Member

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@ashutoshgngwr ashutoshgngwr added the enhancement New feature or request label Jun 15, 2020
@ashutoshgngwr ashutoshgngwr added this to the 0.8.x milestone Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #198 into master will increase coverage by 1.54%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   85.88%   87.42%   +1.54%     
==========================================
  Files          19       22       +3     
  Lines        1020     1177     +157     
  Branches      101      135      +34     
==========================================
+ Hits          876     1029     +153     
- Misses         73       75       +2     
- Partials       71       73       +2     
Flag Coverage Δ
#android 86.07% <85.71%> (+0.18%) ⬆️
#cast_receiver 97.79% <ø> (?)
#ui_tests 61.73% <85.71%> (+0.89%) ⬆️
#unit_tests 46.09% <0.00%> (+6.01%) ⬆️
Impacted Files Coverage Δ
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 77.50% <85.71%> (+1.74%) ⬆️
cast-receiver/src/player_manager.ts 97.59% <0.00%> (ø)
cast-receiver/src/status_ui_handler.ts 98.03% <0.00%> (ø)
cast-receiver/src/library.mock.js 100.00% <0.00%> (ø)
...hub/ashutoshgngwr/noice/fragment/DialogFragment.kt 81.66% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275d660...72ef629. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 5553b32 into master Jun 15, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/main-activity/play-pause-toggle branch June 15, 2020 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant