Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes play button not responding to clicks #161

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

ashutoshgngwr
Copy link
Member

Issue #159 happens because service is stopped when activity is paused
for sometime after stopping the playback.

Changes

  • Move startService call from onCreate to onResume

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

Issue #159 happens because service is stopped when activity is paused
for sometime after stopping the playback.
@ashutoshgngwr ashutoshgngwr added the bug-fix Pull requests that propose bug fixes label May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #161 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #161      +/-   ##
============================================
+ Coverage     81.50%   81.52%   +0.02%     
- Complexity      129      130       +1     
============================================
  Files            12       12              
  Lines           849      850       +1     
  Branches         86       86              
============================================
+ Hits            692      693       +1     
  Misses           92       92              
  Partials         65       65              
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 80.89% <100.00%> (+0.21%) 18.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ec373...f06bff8. Read the comment docs.

@ashutoshgngwr ashutoshgngwr added this to the 0.7.1 milestone May 14, 2020
@ashutoshgngwr ashutoshgngwr force-pushed the master branch 2 times, most recently from 06575ac to 6d31fda Compare May 18, 2020 07:14
@ashutoshgngwr ashutoshgngwr merged commit cf827c3 into master May 18, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/issue/159 branch May 18, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that propose bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play button in Sound library not responding
1 participant