-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update openapi.yaml: add session_id, start_time, and skip_prev_cursor #187
Conversation
WalkthroughThis pull request updates the API specification in Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API_Server
Client->>API_Server: GET /api/v1/runs/{run_id}?session_id=...&start_time=...
API_Server-->>Client: Returns filtered run details
sequenceDiagram
participant Client
participant API_Server
Client->>API_Server: POST /api/v1/runs/query (with skip_prev_cursor field)
API_Server-->>Client: Returns queried runs with adjusted pagination
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/LangSmith/openapi.yaml (1)
4324-4337
: Review: Addingsession_id
andstart_time
Query ParametersThe new query parameters
session_id
andstart_time
are well-defined with clear type specifications, format validations, and nullable settings. This addition enhances the endpoint's filtering capabilities. As an improvement, consider including a briefdescription
for each parameter to better guide API consumers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
src/libs/LangSmith/Generated/LangSmith.IPublicClient.QuerySharedDatasetRuns.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.IRunClient.QueryRuns.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.IRunClient.ReadRun.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.Models.BodyParamsForRunSchema.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.PublicClient.QuerySharedDatasetRuns.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.RunClient.QueryRuns.g.cs
is excluded by!**/generated/**
src/libs/LangSmith/Generated/LangSmith.RunClient.ReadRun.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/LangSmith/openapi.yaml
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test / Build, test and publish
🔇 Additional comments (1)
src/libs/LangSmith/openapi.yaml (1)
12767-12770
: Review: Inclusion ofskip_prev_cursor
in BodyParamsForRunSchemaThe new field
skip_prev_cursor
is specified correctly as a boolean with a default value of false, which aligns with pagination improvements discussed. Optionally, adding adescription
field could clarify its intended behavior for API users.
Summary by CodeRabbit