Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JVM memory leak fix #4070

Closed
wants to merge 11 commits into from
Closed

JVM memory leak fix #4070

wants to merge 11 commits into from

Conversation

vcoolish
Copy link
Contributor

@vcoolish vcoolish commented Oct 17, 2024 •
edited
Loading

Fixes #4021

Changes:

  • Created phantom reference registry with one thread which cleans up objects when needed.
  • Also added instrumentation testing support for kotlin target, for KMP testing purposes.

@vcoolish vcoolish self-assigned this Oct 17, 2024
@vcoolish vcoolish changed the base branch from master to dev October 17, 2024 19:54
@vcoolish vcoolish changed the base branch from dev to master October 17, 2024 19:55
@vcoolish vcoolish marked this pull request as ready for review October 17, 2024 19:56
@vcoolish vcoolish marked this pull request as draft October 17, 2024 19:57
@10gic
Copy link
Contributor

10gic commented Oct 18, 2024

Hi @vcoolish, could you explain a little bit why the old code doesn't work?

@vcoolish
Copy link
Contributor Author

Hi @vcoolish, could you explain a little bit why the old code doesn't work?

because it did register, but never did clean up. so it was a useless implementation of reference registry without actual logic inside to clean up references, only to track them.

@10gic 10gic mentioned this pull request Oct 29, 2024
Open
satoshiotomakan and others added 8 commits November 1, 2024 21:50
@satoshiotomakan @vcoolish
Fix JNI Linux CI (#4065)
244f5fb 
* Add linux-ci-jni.yml for tests only

* Fix compilation

* Include algorithm

* Delete linux-ci-jni.yml
@10gic @satoshiotomakan @vcoolish
[Aptos]: Fix an issue in deserializing the EntryFunction object (#4011)
8f3217a 
* Fix an issue in deserializing the EntryFunction object

* Add more test cases

---------

Co-authored-by: satoshiotomakan <127754187+satoshiotomakan@users.noreply.github.com>
@satoshiotomakan @vcoolish
Update Package.swift version to 4.1.12 (#4067)
60a20f3
@satoshiotomakan @vcoolish
Upgrade to Ubuntu 24.04 explicitly (#4068)
4ffd74d
@vcoolish
Support android instrumented tests on KMP
6c2e601
@vcoolish
Fix Java memory leak
93e8d97
@vcoolish
typo
c1800c5
@vcoolish
Merge remote-tracking branch 'origin/jvm-leak' into jvm-leak
9812410
@vcoolish vcoolish changed the base branch from master to dev November 1, 2024 17:51
@vcoolish vcoolish closed this Nov 1, 2024
@vcoolish vcoolish deleted the jvm-leak branch November 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ar-g ar-g Awaiting requested review from ar-g ar-g is a code owner

@JaimeToca JaimeToca Awaiting requested review from JaimeToca JaimeToca is a code owner

@rkokhatskyi rkokhatskyi Awaiting requested review from rkokhatskyi rkokhatskyi is a code owner

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

@satoshiotomakan satoshiotomakan Awaiting requested review from satoshiotomakan satoshiotomakan is a code owner

Assignees

@vcoolish vcoolish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KMP] Memory leak found in AnyAddress
3 participants
@vcoolish @10gic @satoshiotomakan