feat(sdk): openid4vp PresentCredential uses multi-presentation format #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 90.56% 90.29% -0.27%
==========================================
Files 54 54
Lines 2278 2359 +81
==========================================
+ Hits 2063 2130 +67
- Misses 148 156 +8
- Partials 67 73 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vkubiv
approved these changes
Mar 6, 2023
Moopli
changed the title
Moopli
force-pushed
the
multi-pres
branch
3 times, most recently
from
bdffb3f to
f729f2b
Compare
- PresentCredential now takes Credentials as parameters instead of requiring a Query operation to create a Presentation - When multiple Credentials are provided, a Presentation is created for each Credential, and serialized to compact JWS. vp_token is set to a JSON array of these presentation JWS strings. - For the purposes of JSONPath references in presentation exchange, the JSONPath root is this JSON array, where each presentation JWS is replaced by said presentation's JSON representation. Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
|
Kudos, SonarCloud Quality Gate passed!
|
rolsonquadras
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiring a Query operation to create a Presentation
for each Credential, and serialized to compact JWS. vp_token is
set to a JSON array of these presentation JWS strings.
the JSONPath root is this JSON array, where each presentation JWS
is replaced by said presentation's JSON representation.